[FIX] dashboard: properly handle grid resize in dashboard mode #7404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
|
if I understand the issue correctly, we miss the actual computation of the spreadsheet width when in dashboard mode. have you looked into a way to correct that as well? because right now we have a discrepency between the canvas size and the actual part displayed to the client and I'm not sure that just hiding it is the best solution (maybe it's too complicated to fix and it's the right call, but i'm curious to know if looked into it) |
rmbh-odoo
force-pushed
the
saas-18.4-fix-dashboard-gray-background-rmbh
branch
from
327e1bc to
4650b73
Compare
rmbh-odoo
changed the title
rmbh-odoo
commented
Nov 12, 2025
rrahir
requested changes
Nov 12, 2025
rmbh-odoo
force-pushed
the
saas-18.4-fix-dashboard-gray-background-rmbh
branch
2 times, most recently
from
361261b to
d525807
Compare
rrahir
reviewed
Nov 17, 2025
|
|
||
| onGridResized({ height, width }: DOMDimension) { | ||
| onGridResized() { | ||
| const { height, width } = this.props.getGridSize(); |
Collaborator
There was a problem hiding this comment.
I guess we could go a bit further and make a helper because those lines are a repetition of the computation in get gridContainer() ;-)
Before this commit: - The canvas size was computed from the grid, which caused visible white margins after a snappy resize (commit 3c8df4b). - Some unused props were being passed, creating unnecessary code clutter. After this commit: - The dashboard canvas size is now computed as the min of the grid bounds and the end of getColDimension. - Shows only visible parts and avoids extra canvas processing. Task: 5223156
rmbh-odoo
force-pushed
the
saas-18.4-fix-dashboard-gray-background-rmbh
branch
from
d525807 to
6982b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current behavior before PR:
after a snappy resize (commit 3c8df4b9).
Desired behavior after PR is merged:
visible parts are displayed and avoiding redundant canvas computations.
Task: 5223156
review checklist