Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 14, 2025

Description:

Before this commit:

  • splitReference removed single quotes from sheet names.

After this commit:

  • Applied getCanonicalSymbolName after splitReference to ensure sheet
    Names with spaces keep their quotes.

Task: 5244798

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7409

Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

Task: 5244798
X-original-commit: 2a23ddd
@robodoo
Copy link
Collaborator

robodoo commented Nov 14, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 14, 2025

This PR targets 19.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 14, 2025

@rmbh-odoo @LucasLefevre the next pull request (#7465) is in conflict. You can merge the chain up to here by saying

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants