Open
Conversation
mmahrouss
force-pushed
the
alpha-xml-models-mdms
branch
6 times, most recently
from
dfb81f8 to
00bf4ba
Compare
mmahrouss
commented
Mar 18, 2026
| } | ||
| // Also compute mandatory fields from XML-defined ir.model.fields records | ||
| for (field_name, field_records) in xml_field_records.iter() { | ||
| if mandatory_fields.contains(field_name) { |
Collaborator
Author
There was a problem hiding this comment.
What if an XML field is just added to make a field not required?
mmahrouss
force-pushed
the
alpha-xml-models-mdms
branch
3 times, most recently
from
65c3b4f to
7336cc3
Compare
mmahrouss
force-pushed
the
alpha-xml-models-mdms
branch
3 times, most recently
from
87c9a99 to
62c1484
Compare
mmahrouss
changed the title
Collaborator
|
can you rebase this one too? @mmahrouss |
This adds xml models and fields in the model struct. It is also handled in hover, definition, ... . Also includes tests
mmahrouss
force-pushed
the
alpha-xml-models-mdms
branch
from
62c1484 to
594510a
Compare
Collaborator
Author
|
@fda-odoo rebased |
fda-odoo
requested changes
Mar 20, 2026
Collaborator
fda-odoo
left a comment
fda-odoo
left a comment
There was a problem hiding this comment.
We have to discuss this PR, because I think a refactoring is needed at this point.
Model class has been designed to only keep reference to symbols that build the model. Here it holds copies of OdooDataRecord.
Maybe we have to update the structure so that OdooDataRecord are part of the Symbol tree.
get_member is wrong too, as it is not browsing xml_symbols added to Model, same for all_members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on the fix to go to def on XMl panicking or going to wrong file https://github.com/odoo/odoo-ls/pull/551/changes#r2953025503