[IMP] tests: only persistent table must have a primary key#159
Open
Pirols wants to merge 1 commit intoodoo:masterfrom
Open
[IMP] tests: only persistent table must have a primary key#159Pirols wants to merge 1 commit intoodoo:masterfrom
Pirols wants to merge 1 commit intoodoo:masterfrom
Conversation
In some cases, it can be handy to define an unlogged/temporary table to memontarily store information from before the upgrade. We don't care for such non persistent tables to have a primary key.
Contributor
|
|
Contributor
|
Actually, there is a real bug in the odoo/upgrade#6690 PR: the temporary table hasn't been cleaned up by the upgrade script (due to the early return check). |
Contributor
Author
Indeed, the CI only raised due to that mistake. On the other hand, the logs still display that error: Anyways, it's not blocking and I wouldn't have opened this PR for that alone, feel free to close or merge it, as you see fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, it can be handy to define an unlogged/temporary table to memontarily store information from before the upgrade. We don't care for such non persistent tables to have a primary key.
Failure example: https://upgradeci.odoo.com/upgradeci/run/170069