[IMP] snippets.convert_html_content by duau-odoo · Pull Request #399 · odoo/upgrade-util

duau-odoo · 2026-03-26T16:40:19Z

No description provided.

robodoo · 2026-03-26T16:40:23Z

KangOl · 2026-03-27T09:33:09Z

+    modules = _website_dependent_modules(cr)
+    if not modules:
+        return


You can change this html_fiels function has it will impact existing scripts.
You need a new function snippet_fields that return only the field that can contain snippets.

Yes it will impact existing scripts, but I think, if the list is done properly, it would be better to also improve existing scripts and not only futures one? Or is that too big of a risk ?

We can change existing scripts to use this new function when needed.

duau-odoo · 2026-03-30T08:34:54Z

@KangOl what do you think about this solution ?

KangOl · 2026-03-30T15:14:40Z

+def _website_dependent_modules(cr):
+    cr.execute(
+        """
+        WITH RECURSIVE website_dependent_modules AS (
+            SELECT 'website'::varchar AS name
+            UNION
+            SELECT m.name
+              FROM ir_module_module m
+              JOIN ir_module_module_dependency d ON d.module_id = m.id
+              JOIN website_dependent_modules w ON w.name = d.name
+             WHERE m.state = 'installed'
+        )
+        SELECT name
+          FROM website_dependent_modules
+        """
+    )
+    return [name for (name,) in cr.fetchall()]


No need to have a separated function. The CTE can be directly included in the below query.

Other issues:

you can't always consider website to be installed.

and installed is not the correct state to check. Use util.INSTALLED_MODULE_STATES

the starting modules are version dependent. From Odoo 19, it's html_builder. Before, it was website and mass_mailing.

KangOl · 2026-03-30T15:17:20Z

    cr,
    converter_callback,
    where_column="IS NOT NULL",
+    only_website_snippets=False,


Maybe we can be future-proof and use an enum instead of a boolean (this file is python3 only)

FieldScope(Enum): ALL = 1 SNIPPETS = 2

Suggested change

only_website_snippets=False,

scope=FieldScope.ALL,

nseinlet

LGTM

aj-fuentes · 2026-03-31T14:38:12Z

+        SELECT model, array_agg(name)
+          FROM _fields
+      GROUP BY model


just for consistent order across runs

Suggested change

SELECT model, array_agg(name)

FROM _fields

GROUP BY model

SELECT model, array_agg(name ORDER BY name)

FROM _fields

GROUP BY model

ORDER BY model

aj-fuentes · 2026-03-31T14:40:38Z

    :param str where_column: filtering such as
        - "like '%abc%xyz%'"
        - "~* '\yabc.*xyz\y'"
+    :param bool only_website_snippets: when True, only process stored HTML fields


The docstring is misaligned with the scope parameter.

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed.

Sort fields to have a consistent execution across upgrades.

aj-fuentes

Looks good. Minimal comment.

Add parameter to targetting only snippets fields. This accelerate the update by not searching on fields that cannot contain snippets, like tasks or leads. Co-authored-by: Augustin (duau) <duau@odoo.com>

KangOl

@robodoo rebase-ff r+

robodoo · 2026-04-01T14:49:23Z

Merge method set to rebase and fast-forward.

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Add parameter to targetting only snippets fields. This accelerate the update by not searching on fields that cannot contain snippets, like tasks or leads. closes #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com> Co-authored-by: Augustin (duau) <duau@odoo.com>

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Add parameter to targetting only snippets fields. This accelerate the update by not searching on fields that cannot contain snippets, like tasks or leads. closes #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com> Co-authored-by: Augustin (duau) <duau@odoo.com>

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

duau-odoo force-pushed the master-perf-snippets-utils-duau branch from 5e4462a to 0883fe9 Compare March 27, 2026 09:20

KangOl reviewed Mar 27, 2026

View reviewed changes

duau-odoo force-pushed the master-perf-snippets-utils-duau branch from 0883fe9 to f73efd4 Compare March 27, 2026 11:46

KangOl requested changes Mar 30, 2026

View reviewed changes

nseinlet reviewed Mar 31, 2026

View reviewed changes

KangOl requested a review from aj-fuentes March 31, 2026 14:27

aj-fuentes reviewed Mar 31, 2026

View reviewed changes

KangOl added 2 commits March 31, 2026 17:30

[FIX] snippets.html_fields

cb63329

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed.

[IMP] snippets.html_fields

9aa72c3

Sort fields to have a consistent execution across upgrades.

KangOl force-pushed the master-perf-snippets-utils-duau branch from 8a46a2c to 3cbbb13 Compare March 31, 2026 15:38

aj-fuentes approved these changes Apr 1, 2026

View reviewed changes

Comment thread src/util/snippets.py Outdated

Comment thread src/util/snippets.py Outdated

[IMP] snippets.convert_html_content

2b72f80

Add parameter to targetting only snippets fields. This accelerate the update by not searching on fields that cannot contain snippets, like tasks or leads. Co-authored-by: Augustin (duau) <duau@odoo.com>

KangOl force-pushed the master-perf-snippets-utils-duau branch from 3cbbb13 to 2b72f80 Compare April 1, 2026 10:32

KangOl changed the title ~~[IMP] WIP only target website_* fields for snippets upgrade~~ [IMP] snippets.convert_html_content Apr 1, 2026

KangOl marked this pull request as ready for review April 1, 2026 10:39

aj-fuentes approved these changes Apr 1, 2026

View reviewed changes

KangOl approved these changes Apr 1, 2026

View reviewed changes

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[FIX] snippets.html_fields

0c3878e

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[IMP] snippets.html_fields

109b7a7

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[FIX] snippets.html_fields

8e225a6

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[IMP] snippets.html_fields

eeb04a8

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[FIX] snippets.html_fields

cb38068

Ignore `mail.mail` fields. Outgoing email content doesn't need to be changed. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo pushed a commit that referenced this pull request Apr 1, 2026

[IMP] snippets.html_fields

6f81931

Sort fields to have a consistent execution across upgrades. Part-of: #399 Related: odoo/upgrade#9792 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

robodoo closed this in f455c09 Apr 1, 2026

robodoo added the 19.3 label Apr 1, 2026

robodoo temporarily deployed to merge April 1, 2026 21:55 Inactive

Conversation

duau-odoo commented Mar 26, 2026 • edited by KangOl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Mar 26, 2026

Uh oh!

KangOl Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

duau-odoo Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

KangOl Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

duau-odoo commented Mar 30, 2026

Uh oh!

KangOl Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

KangOl Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

nseinlet left a comment

Choose a reason for hiding this comment

Uh oh!

aj-fuentes Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

aj-fuentes Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

aj-fuentes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KangOl left a comment

Choose a reason for hiding this comment

Uh oh!

robodoo commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

duau-odoo commented Mar 26, 2026 •

edited by KangOl

Loading