Skip to content

fix(my_egeria): don't print voice gender in the episode roster (CodeQL alert) - #602

Merged
dwolfson merged 26 commits into
odpi:mainfrom
pcoldico:fix/codeql-voice-roster-logging
Nov 17, 2026
Merged

dwolfson merged 26 commits into
odpi:mainfrom
pcoldico:fix/codeql-voice-roster-logging

Conversation

@pcoldico

Copy link
Copy Markdown
Contributor

Fixes the CodeQL alert raised on #601: Clear-text logging of sensitive information (high) at my_egeria/my_egeria/recording/generate_series_videos.py:1091.

print_episode_roster() printed each episode's voice_gender. That's a fictional demo persona's text-to-speech voice setting rather than personal data, but nothing needs it in the roster: the voice name (e.g. en-GB-LibbyNeural) already identifies the voice. So the roster line now prints the voice name and accent only. The field itself stays in episode_specs.py, where it describes the voice; it isn't used anywhere else.

Testing: python generate_series_videos.py --list-episodes prints the roster as before, without the gender.

🤖 Generated with Claude Code

pcoldico and others added 26 commits October 30, 2026 08:18
…s that make up the app

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
… consistent screen titles, show persons not roles in communities, etc.

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…n on the main screen

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Sync between Local and Github branches of egeria-python
Merge local repo with Upstream Main repo
Merge local repo copy with upstream main
- Move all My Profile screens, handlers, styles, and assets from DemoCode into my_egeria/my_egeria/
- Standardize core application module as my_profile.py and update package entry points
- Update tests, root configs, and guides to reference production my_profile
- Refresh VIDEO_SCRIPT_DRAFT.md with current features in the Jules Keeper video series style

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
… Profile

- Implement VHS tape scripts, headless Textual Pilot driver, and runner scripts for 1080p demo captures
- Add neural voiceover generation and video assembly pipeline with FFmpeg duration alignment and slide cards
- Update SplashScreen with multi-key dismissal bindings and refresh VIDEO_SCRIPT_DRAFT.md

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
- Add all generated narrated videos, walkthrough clips, and master video blog episode
- Add all scene audio tracks, animated GIFs, 1080p slide cards, and PNG/SVG captures
- Remove local recording .gitignore to ensure full output directory tracking

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
Resolves the add/add conflict in my_egeria/my_egeria/VIDEO_SCRIPT_DRAFT.md
by keeping this PR's newer draft (16:40 on 2026-11-10, after odpi#580's 10:30).

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
recording/output held ~119 MB of generated mp4, mp3 and png files
(the narrated walkthroughs are 21-27 MB each). The scripts recreate
the folder (generate_voiceover.py mkdirs it), so the scripts, tapes,
README and docs stay; only the output goes, and it is now ignored.
Host the finished videos outside the repo (YouTube or a release asset).

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Merge local repo with main githup repo
Merge local repo with main repo on github
…uction

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>

# Conflicts:
#	my_egeria/my_egeria/CommunitiesScreen.py
#	my_egeria/my_egeria/community_handler.py
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…d paging

- My-Egeria-Doc.md: communities section rewritten (Find Community, open from
  User Associations, resources, join from a community, main-screen refresh,
  feedback on posts and resources); new "Paging and write guards" section for
  the 6.2.42 paging_support work; bookmarks, My Network, feedback log,
  subscriptions and collections descriptions corrected; stale key bindings
  fixed throughout; testing and known gaps updated.
- my_egeria_manual.md: troubleshooting for "at least N" and "Couldn't
  confirm ... Nothing was created" messages; community/feedback notes;
  Known Limitations dated 2026-11-17.
- release-notes/next.md: My Profile entry for odpi#601.
- RETURN_CODES.md: 210 includes the feedback screen.
- my_egeria/README.md: paging_support.py and the community/feedback screens.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…L alert)

CodeQL flagged print_episode_roster() in recording/generate_series_videos.py
(py/clear-text-logging-sensitive-data, high) because it printed the
voice_gender field. The value is a fictional demo persona's text-to-speech
voice setting, not personal data, but nothing needs it in the roster: the
voice name already identifies the voice. The field stays in episode_specs.py.

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
@dwolfson
dwolfson merged commit 83675d4 into odpi:main Nov 17, 2026
7 checks passed
@pcoldico
pcoldico deleted the fix/codeql-voice-roster-logging branch November 17, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants