-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: add shared to cmake extension #159
FEAT: add shared to cmake extension #159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 11 11
Lines 566 566
Branches 67 67
=======================================
Hits 485 485
Misses 45 45
Partials 36 36 |
…o-cmake-extension
…o-cmake-extension # Conflicts: # .github/workflows/build.yml
…o-cmake-extension # Conflicts: # .github/scripts/build-windows-wheels.sh # setup.py
…o-cmake-extension
Is this still relevant? I'm sorry I don't have much time to look into it! If so I will merge. |
Well, yes it is. It only adds a n additional workflow to verify that shared library can be used. It is not urgent or critical. It's better to review it, in fact I need to remove the |
What's this, a hash of the source tar ball? Line 82 in adff792
|
Yes, I think I used it in the CMake fetching the secp256k1 tarball. It's likely the
|
This adds a verification flow to check that a shared build works