Various updates

[ofek]

No description provided.

[gemini-code-assist]

Hello @ofek, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request includes several updates. It disables the summary and code review features for pull request openings in the Gemini configuration, updates the pyproject.toml file to use pkgconf instead of pypkgconf on Windows, and removes the explicit dependency on cffi in pyproject.toml.

Highlights

• Configuration Update: The Gemini configuration file is updated to disable automatic summary and code review upon pull request opening.
• Dependency Management: The pyproject.toml file is updated to use pkgconf instead of pypkgconf on Windows and removes the explicit dependency on cffi.

Changelog

• .gemini/config.yaml
  • Disabled summary generation on pull request open.
  • Disabled code review on pull request open.
• pyproject.toml
  • Replaced pypkgconf with pkgconf for Windows.
  • Removed explicit cffi dependency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A config file, a project's heart,
Dependencies listed, playing their part.
From pypkgconf to pkgconf's grace,
And cffi's removal, finding its place.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request includes several updates, including changes to the .gemini/config.yaml and pyproject.toml files. The changes to pyproject.toml involve updating dependencies. Overall, the changes seem straightforward.

Merge Readiness

The changes appear to be relatively minor. Given the limited scope and the absence of any identified critical or high-severity issues, the pull request seems to be in reasonable shape to be merged. However, it's always a good practice to have another reviewer take a look before merging. I am unable to approve the pull request, and users should have others review and approve this code before merging.

[ofek]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request includes several updates to the project. It disables summary and code review generation in the gemini config, updates the macOS version used in GitHub Actions workflows, modifies the build.py script to replace a specific string, removes cffi as a runtime dependency, and introduces a custom build hook to include the _cffi_backend extension module in the wheel. It also updates the pyproject.toml file to reflect these changes.

Highlights

• Gemini Configuration: Disables summary and code review generation in the .gemini/config.yaml file.
• GitHub Actions: Updates the runs-on value for macOS jobs in .github/workflows/build.yml and .github/workflows/verify_shared_build.yml from macos-latest to macos-13.
• CFFI Backend: Modifies cm_library_c_binding/build.py to replace PyImport_ImportModule("_cffi_backend") with PyImport_ImportModule("coincurve._cffi_backend").
• Dependency Management: Removes cffi as a runtime dependency and adds a custom build hook in hatch_build.py to include the _cffi_backend extension module in the wheel.
• Project Configuration: Updates pyproject.toml to remove cffi as a direct dependency, replace pypkgconf with pkgconf and configure the custom build hook.

Changelog

• .gemini/config.yaml
  • Disabled summary and code review generation for pull request opened events.
• .github/workflows/build.yml
  • Updated macOS version for build jobs from macos-latest to macos-13.
• .github/workflows/verify_shared_build.yml
  • Updated macOS version for build jobs from macos-latest to macos-13.
• cm_library_c_binding/build.py
  • Replaced PyImport_ImportModule("_cffi_backend") with PyImport_ImportModule("coincurve._cffi_backend") in the generated C code.
• docs/history.md
  • Added a note indicating that cffi is no longer a runtime dependency.
• hatch_build.py
  • Implemented a custom build hook to include the _cffi_backend extension module in the wheel, removing the runtime dependency on cffi.
  • Copies the cffi license file into the distribution.
• pyproject.toml
  • Replaced pypkgconf with pkgconf as a build dependency for Windows.
  • Removed cffi as a direct dependency.
  • Configured the custom build hook.

Activity

• ofek created the pull request.
• ofek requested a summary from gemini-code-assist.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (ddfa9bb) to head (4fb1d34).
Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #176       +/-   ##
===========================================
+ Coverage   33.68%   79.52%   +45.83%     
===========================================
  Files          12       13        +1     
  Lines         567      625       +58     
  Branches       67       49       -18     
===========================================
+ Hits          191      497      +306     
+ Misses        376       91      -285     
- Partials        0       37       +37     

Files with missing lines	Coverage Δ
tests/conftest.py	100.00% <ø> (ø)
tests/test_flags.py	100.00% <100.00%> (ø)
tests/test_keys.py	100.00% <100.00%> (ø)
tests/test_utils.py	100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes