Fix file extension replacement in node module#211
Open
parasyte wants to merge 2 commits intoolado:masterfrom
Open
Fix file extension replacement in node module#211parasyte wants to merge 2 commits intoolado:masterfrom
parasyte wants to merge 2 commits intoolado:masterfrom
Conversation
Collaborator
|
@parasyte thank you. let me review and I will merge. Don't worry about coverage getting down - it's actually better now as another file has the test. |
Collaborator
|
I like the change, but given that the way it works now is, arguably, "a feature" and this change may break some users' code, the change should go in v2. I think it's time to create a branch for v2 and we can release it to npm as beta. Please give me some time - I will let you know. |
Collaborator
|
@parasyte It would be helpful if you could submit some passing test, without code changes, as a separate PR in the meanwhile. |
Collaborator
|
@parasyte just created branch v2.0.0. Please submit:
Then I can merge it all and deploy 2.0.0 as beta version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase for #138
I discovered a bug with filename extension removal in
dot.processwhen using additional.characters in the filename. Example directory structure:Processed with:
Outputs the following keys:
The expected "glsl" extension has been removed. The patch fixes this issue by using
String.prototype.replaceinstead of locating the first.character.