fix: add __version__ attribute to package#635
Open
abdelhadi703 wants to merge 1 commit intoollama:mainfrom
Open
fix: add __version__ attribute to package#635abdelhadi703 wants to merge 1 commit intoollama:mainfrom
abdelhadi703 wants to merge 1 commit intoollama:mainfrom
Conversation
The ollama package was missing a __version__ attribute, causing AttributeError when users try to access ollama.__version__. This fix adds __version__ using importlib.metadata.version() which reads the version from package metadata (set by hatch-vcs from git tags). Falls back to '0.0.0' if metadata is unavailable. Fixes ollama#623 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pawansingh3889
left a comment
Pawansingh3889
left a comment
There was a problem hiding this comment.
Nice addition — this solves a real usability gap.
One suggestion: consider catching PackageNotFoundError specifically (from importlib.metadata) rather than the broad except Exception. That way genuine unexpected errors during development still surface instead of silently falling back to 0.0.0.
Also, since __version__ is now exported via __all__, it would be worth adding a quick test for from ollama import __version__ to guard against regressions.
LGTM with the narrow exception suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ollama package was missing a
__version__attribute, causingAttributeError: module 'ollama' has no attribute '__version__'when users try to accessollama.__version__.Changes
__version__attribute usingimportlib.metadata.version('ollama')'0.0.0'if metadata is unavailable (e.g., when running from source)'__version__'to__all__for proper exportsTesting
Fixes #623