Update renamed clojurescript fn #914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [change to cljs.core][1] renamed the `warn-and-update-protocol` fn, which om relies on via a macro. The clojurescript commit simply changes the name to `update-protocol-var`, so this commit in om does the same. [1]: clojure/clojurescript@13fde33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to cljs.core renamed the
warn-and-update-protocolfn, which om relies on via a macro. The clojurescript commit simply changes the name toupdate-protocol-var, so this commit in om does the same.@swannodette would appreciate your thoughts - this unblocks clojurescript upgrades on om.next projects, so I'd love to see it in!