Fix isBridgeContract handler in burner wallet plugin#467
Fix isBridgeContract handler in burner wallet plugin#467k1rill-fedoseev wants to merge 1 commit intodevelopfrom
Conversation
| return allowedModes.includes(mode) | ||
| } catch (e) { | ||
| return false | ||
| if (e.message.includes("Returned values aren't valid")) { |
There was a problem hiding this comment.
What is your advise to verify this functionality with the Infura or xDai rpc endpoints?
There was a problem hiding this comment.
Well, I would suggest to add an additional console.log statement here, which will print out the e.message, so that we can see what kind of errors get in different situations.
In my local experiments, the error starting from Returned values aren't valid happened only when the callee was either an EOA or some non-bridge contract. Also, seems that this error is raised from the web3js library, so the error message should not depend on the particular JSON-RPC implementation.
|
@k1rill-fedoseev should we update the corresponding NPM package and reference to it here: https://github.com/poanetwork/tokenbridge-burner-wallet-plugin/blob/71e816b40104d2a0b1bccac4afbb2023f686efe1/yarn.lock#L2361? |
2 participants
Closes #445