Fix woman-* and man-* short codes are now *_woman and *_man on GitHub#112
Open
rhysd wants to merge 3 commits intoomnidan:masterfrom
Open
Fix woman-* and man-* short codes are now *_woman and *_man on GitHub#112rhysd wants to merge 3 commits intoomnidan:masterfrom
woman-* and man-* short codes are now *_woman and *_man on GitHub#112rhysd wants to merge 3 commits intoomnidan:masterfrom
Conversation
aidenlx
added a commit
to aidenlx/obsidian-icon-shortcodes
that referenced
this pull request
Nov 5, 2021
gasolin
approved these changes
Nov 9, 2021
|
@omnidan Are there any plans to merge this? |
|
bump |
JoshuaKGoldberg
added
the
status: blocked
Collaborator
|
👋 Heyall, new junior maintainer here picking up old threads - quick status update:
Marking this PR as blocked until we get clarity on what should go in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got an issue report in my project and it turned out that it was a bug of this library.
rhysd/remark-emoji#19
This PR fixes the bug. Many
man-*andwoman-*short codes seem to be renamed to*_manand*_woman. For example,:man-walking:was renamed to:walking_man:🚶🏼♂️. I checked allman-*andwoman-*emojis on GitHub and added new short codes corresponding to them if they're existing.According to Emojipedia,
https://emojipedia.org/man-walking/
:man_walking:(Emojipedia):man-walking:(Slack):walking_man:(Github)