Skip to content

refactor: remove typing extensions from deps and apply future type hint style #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove typing extensions from deps and apply future type hint style #340

wants to merge 1 commit into from

Conversation

@waketzheng
Copy link
Contributor

Description

Feature:

  1. Remove typing_extensions from dependencies list
  2. Apply future type hints style

@waketzheng
Copy link
Contributor Author

  • Why remove typing_extensions
    I check py files in aiosqlite/ and docs/ and ensure that typing_extensions is not imported.
  • How is type hints improved
    Add from __future__ import annotations to py files in aiosqlite/ that imports typing.
    Then run ruff check --extend-select=UP --ignore=UP031 --fix --unsafe-fixes to auto fix issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waketzheng