Skip to content

Bump atuin to v18.6.0 #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Bump atuin to v18.6.0 #1604

merged 2 commits into from
May 16, 2025

Conversation

papertigers
Copy link
Contributor

This bumps atuin to the latest release aka v18.6.0.

I built this in my build VM without issue.

@hadfl
Copy link
Member

hadfl commented May 7, 2025

I assume you renamed the source file taken from GitHub? It seems atuin no longer prefixes version tags with a v so this needs to be removed in download_source.

@papertigers
Copy link
Contributor Author

You're right I used a site.sh file and I had pulled the files myself:

omnios@omnios-builder:~/extra-web/atuin$ ls -l
total 2652
-rw-r--r--   1 omnios   other     665686 Apr  9 11:15 v18.5.0.tar.gz
-rw-r--r--   1 omnios   other         81 Apr  9 11:15 v18.5.0.tar.gz.sha256
-rw-r--r--   1 omnios   other     667624 May  6 23:41 v18.6.0.tar.gz
-rw-r--r--   1 omnios   other         81 May  6 23:41 v18.6.0.tar.gz.sha256

If you look at the GitHub releases it seems like there is no standard (a sampling):
18.6.0
v18.5.0
18.5.0-beta.3

Do we want build.sh to just track the latest version scheme?

@hadfl
Copy link
Member

hadfl commented May 7, 2025

Do we want build.sh to just track the latest version scheme?

Well build.sh should always track the version it currently builds. You can always go back to older commits for any software version built and the commit for that will make sure that version scheme matches.

@papertigers
Copy link
Contributor Author

I am happy to drop the v in the build script but let me rephrase a different way.

How are you mirroring the tar.gz today? This seems like a manual step unless there's some sort of automation I am unaware of. This package isn't grabbing the source directly from GitHub.

@citrus-it
Copy link
Member

How are you mirroring the tar.gz today? This seems like a manual step unless there's some sort of automation I am unaware of. This package isn't grabbing the source directly from GitHub.

Yes, it's manual (and to satisfy some licences that require us to provide the source if we're providing binaries). We just keep the names the same as the origin. It's going to be a pain if there is no consistency upstream, but let's switch to the format of the latest and see how it goes.

@papertigers
Copy link
Contributor Author

Sounds good to me, just pushed an update that drops the leading "v"

@hadfl hadfl merged commit 347d121 into omniosorg:master May 16, 2025
1 check passed
@papertigers papertigers deleted the mz/atuin branch May 20, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants