fix(exports): convert bool values for SAV exports#3102
Merged
Conversation
6794203 to
68b5de7
Compare
68b5de7 to
55e4c2f
Compare
FrankApiyo
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Confirmed the regression test fails before the fix with:
text
AttributeError: 'bool' object has no attribute 'ljust'
Confirmed the targeted tests pass after the fix:
python manage.py test \ onadata.libs.tests.utils.testexporttools.TestExportTools.testencodeifstr \ onadata.libs.tests.utils.testexportbuilder.TestExportBuilder.testzippedsavexportwithboolstringvalue \ --settings=onadata.settings.githubactionstestSide effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #3082
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.