This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Fixed placement between the alert and the keyboard#24
Open
pmkowal wants to merge 1 commit intoondalabs:masterfrom
Open
Fixed placement between the alert and the keyboard#24pmkowal wants to merge 1 commit intoondalabs:masterfrom
pmkowal wants to merge 1 commit intoondalabs:masterfrom
Conversation
- added class `OLGhostAlertWindow` which is responsible for displaying an OLGhostAlertView above the application keyWindow. It has methods to show/hide alert above the application main window, which allows it to be independent of the system keyboard. - removed properties in `OLGhostAlertView` that are no longer needed: `keyboardIsVisible`, `keyboardHeight` - added new properties in `OLGhostAlertView`: `alertWindow`, `viewController` - modified methods responsible for initialization, showing/hiding the alert and laying out subviews - removed methods and notifications related to the keyboard, which are no longer needed: `keyboardWillShow:`, `keyboardWillHide`, `UIKeyboardWillShowNotification`, `UIKeyboardWillHideNotification` - set method `showInView:` as deprecated
pmkowal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made regarding an issue #3:
OLGhostAlertWindowwhich is responsible for displayingan OLGhostAlertView above the application keyWindow. It has methods to
show/hide alert above the application main window, which allows it to
be independent of the system keyboard.
OLGhostAlertViewthat are no longer needed:keyboardIsVisible,keyboardHeightOLGhostAlertView:alertWindow,viewControlleralert and laying out subviews
no longer needed:
keyboardWillShow:,keyboardWillHide,UIKeyboardWillShowNotification,UIKeyboardWillHideNotificationshowInView:as deprecated