Add tests for pool from pointer to poolFixtures.hpp #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
3 tasks
ldorau
force-pushed
the
Add_tests_for_pool_from_pointer_to_poolFixtures.hpp
branch
from
eb70506 to
fc474d5
Compare
|
Should we create a separate PR with the test (e.g. the last commit in this PR) and merge it. As I understand the test itself is generic and can be used with different pools/providers. |
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_tests_for_pool_from_pointer_to_poolFixtures.hpp
branch
from
fc474d5 to
44b393d
Compare
KFilipek
reviewed
Feb 26, 2025
|
|
||
| int ret = | ||
| critnib_insert(hTracker->alloc_segments_map, (uintptr_t)ptr, value, 0); | ||
| umf_result_t umf_result = UMF_RESULT_ERROR_UNKNOWN; |
There was a problem hiding this comment.
Move this declaration to be sticked to this if:
if (ret != EEXIST) {Similarly to the int ret = ...
This PR is incorporated into #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for pool from pointer to poolFixtures.hpp.
Depends on: #1134
Checklist