Use atomics in critnib find_* #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes ThreadSanitizer data race in find_predecessor() vs critnib_insert() and critnib_remove(). Signed-off-by: Lukasz Dorau <[email protected]>
5 tasks
vinser52
approved these changes
Mar 10, 2025
lukaszstolarczuk
approved these changes
Mar 10, 2025
KFilipek
approved these changes
Mar 10, 2025
|
The failed CI job will be suppressed in #998 |
ldorau
added a commit
to ldorau/unified-memory-framework
that referenced
this pull request
Mar 10, 2025
Use atomics in find_successor() like in find_predecessor(). Ref: oneapi-src#1175 Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
added a commit
to ldorau/unified-memory-framework
that referenced
this pull request
Mar 11, 2025
Use atomics in find_successor() like in find_predecessor(). Ref: oneapi-src#1175 Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixes ThreadSanitizer data race in find_predecessor() vs critnib_insert() and critnib_remove().
It fixes the following failures:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/13724176734/job/38387107349?pr=998
https://github.com/oneapi-src/unified-memory-framework/actions/runs/13724176734/job/38475443684?pr=998
Checklist