Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit benchmark test to singlethreaded one only #1199

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Mar 18, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner March 18, 2025 12:17
@lplewa lplewa force-pushed the benchmark_limit1 branch 2 times, most recently from 9cc6266 to b83ffac Compare March 18, 2025 12:28
@kswiecicki
Copy link
Contributor

Does this filter those benchmarks?

->Apply(&multithreaded);

If so, it might be more appropriate to remove ->Apply(&multithreaded); when registering the benchmarks.

@lplewa
Copy link
Contributor Author

lplewa commented Mar 18, 2025

Does this filter those benchmarks?

->Apply(&multithreaded);

If so, it might be more appropriate to remove ->Apply(&multithreaded); when registering the benchmarks.

Well we want to have multithreded benchmark as part of benchmarks workflow. This PR is only to disable MT benchmarks as part of "ctest" command

@lplewa lplewa force-pushed the benchmark_limit1 branch from b83ffac to 31c47aa Compare March 18, 2025 12:46
Copy link
Contributor

@PatKamin PatKamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much shorter benchmark tests, thanks!

@lukaszstolarczuk lukaszstolarczuk merged commit 0b784e8 into oneapi-src:main Mar 18, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants