Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Bench] Use new version of bench dashboard #1212

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Mar 20, 2025

incl. using new format of data (stored on 'benchmark-results' branch).

Checklist

  • Remove test commit
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

// Preview:
Job passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/13971793856/job/39115241536
New dashboard: https://oneapi-src.github.io/unified-memory-framework/performance/?notes=true&unstable=false
Results: https://github.com/oneapi-src/unified-memory-framework/tree/benchmark-results

@lukaszstolarczuk
Copy link
Contributor Author

lukaszstolarczuk commented Mar 20, 2025

@lukaszstolarczuk lukaszstolarczuk force-pushed the bump-bench-dashboard branch 2 times, most recently from 4e7543a to 7a26685 Compare March 20, 2025 15:31
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review March 20, 2025 15:32
@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner March 20, 2025 15:32
#
# 20.03.2025
# branch: unify-benchmark-ci
ref: cae7049c78c697b3ac94f931716d9efb53addcd8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few updates today, so you could update if you want.

@@ -38,7 +34,7 @@ jobs:
# Workspace on self-hosted runners is not cleaned automatically.
# We have to delete the files created outside of using actions.
- name: Cleanup self-hosted workspace
if: always()
if: false
run: |
ls -la ./
rm -rf ./* || true
Copy link
Contributor

@KFilipek KFilipek Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for information purposes: It obviously will not delete hidden files (if exists) like ls -la ./ suggests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary at all ;) I removed in from the UR workflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

incl. using new format of data (stored on 'benchmark-results' branch).
@lukaszstolarczuk
Copy link
Contributor Author

finally only minor new changes (Compare) - mostly allow other runners, as in UR.

@PatKamin, please re-review

@PatKamin PatKamin merged commit 5075645 into oneapi-src:main Mar 21, 2025
85 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the bump-bench-dashboard branch March 21, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants