Fix building umfd.dll on single-config generators #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
PatKamin
force-pushed
the
fix-debug-dll
branch
9 times, most recently
from
53468fc to
86b6b28
Compare
kbenzie
reviewed
Apr 4, 2025
CMakeLists.txt
Outdated
Comment on lines
471
to
475
| COMMAND | ||
| ${CMAKE_COMMAND} -E copy_if_different | ||
| ${CMAKE_BINARY_DIR}/umfd_build/bin/Debug/umfd.dll | ||
| ${CMAKE_BINARY_DIR}/bin/$<CONFIG>/umfd.dll |
There was a problem hiding this comment.
When UMF_BUILD_SHARED_LIBRARY=OFF this step will need to be skipped but keep the .lib step.
CMakeLists.txt
Outdated
Comment on lines
486
to
490
| COMMAND | ||
| ${CMAKE_COMMAND} -E copy_if_different | ||
| ${CMAKE_BINARY_DIR}/umfd_build/bin/umfd.dll | ||
| ${CMAKE_BINARY_DIR}/bin/umfd.dll |
PatKamin
force-pushed
the
fix-debug-dll
branch
16 times, most recently
from
f3d4910 to
13d9378
Compare
PatKamin
force-pushed
the
fix-debug-dll
branch
11 times, most recently
from
6b6ad5b to
3cd4c4e
Compare
bratpiorka
approved these changes
Apr 14, 2025
- add installation tests step to Windows generators nightly tests
lukaszstolarczuk
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add installation tests step to Windows generators nightly tests
Checklist
Nightly passed: https://github.com/PatKamin/unified-memory-framework/actions/runs/14398856014