Remove redundant asserts in umfMemspace*Init #1290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
force-pushed
the
no-assert
branch
from
c4a99c6 to
0ff790f
Compare
ldorau
reviewed
Apr 28, 2025
| @@ -105,7 +105,6 @@ static void umfMemspaceHighestBandwidthInit(void) { | |||
| LOG_DEBUG( | |||
| "Creating the highest bandwidth memspace failed with the error: %u", | |||
| ret); | |||
| assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED); | |||
There was a problem hiding this comment.
It can be replaced with: if (ret != UMF_RESULT_ERROR_NOT_SUPPORTED) LOG_FATAL("...")
ldorau
reviewed
Apr 28, 2025
| @@ -101,7 +101,6 @@ static void umfMemspaceLowestLatencyInit(void) { | |||
| LOG_DEBUG( | |||
| "Creating the lowest latency memspace failed with the error: %u", | |||
| ret); | |||
| assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED); | |||
|
@lukaszstolarczuk will you want to continue working on this PR? |
lukaszstolarczuk
force-pushed
the
no-assert
branch
from
0ff790f to
0b956cf
Compare
yes, done. |
lukaszstolarczuk
force-pushed
the
no-assert
branch
from
0b956cf to
2fb62b1
Compare
KFilipek
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// found in #1287