Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L0] Update Level Zero Loader version to v1.18.5 #2279

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[L0] Update Level Zero Loader version to v1.18.5 #2279

merged 1 commit into from
Nov 8, 2024

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Nov 1, 2024

No description provided.

@nrspruit nrspruit requested a review from a team as a code owner November 1, 2024 21:13
nrspruit added a commit to nrspruit/llvm that referenced this pull request Nov 1, 2024
@nrspruit
[UR][L0] Update Level Zero Loader version to v1.18.5
1dd4ef8 
-pre-commit-pr for oneapi-src/unified-runtime#2279

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit mentioned this pull request Nov 1, 2024
Draft
@EwanC
Copy link
Contributor

EwanC commented Nov 4, 2024

I tested this out locally, and still see the SYCL Exception encountered: Native API failed. Native API returns: 2147483646 (UR_RESULT_ERROR_UNKNOWN) error running sycl-ls

@nrspruit
Copy link
Contributor Author

nrspruit commented Nov 4, 2024

I tested this out locally, and still see the SYCL Exception encountered: Native API failed. Native API returns: 2147483646 (UR_RESULT_ERROR_UNKNOWN) error running sycl-ls

Let me check, I wonder if we are having a conflict since MCL symbols are now included.

@nrspruit
Copy link
Contributor Author

nrspruit commented Nov 4, 2024

I tested this out locally, and still see the SYCL Exception encountered: Native API failed. Native API returns: 2147483646 (UR_RESULT_ERROR_UNKNOWN) error running sycl-ls

Let me check, I wonder if we are having a conflict since MCL symbols are now included.

We know this is working correctly with older drivers and libraries, so this must be specific to this configuration.

@EwanC EwanC mentioned this pull request Nov 5, 2024
Open
EwanC
EwanC approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered that the error I'm seeing is to do with a DPC++ build issue I've documented in intel/llvm#15986

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Nov 5, 2024
@callumfare callumfare mentioned this pull request Nov 7, 2024
Merged
@callumfare callumfare merged commit ed9fe09 into oneapi-src:main Nov 8, 2024
84 checks passed
martygrant pushed a commit to intel/llvm that referenced this pull request Nov 8, 2024
@callumfare
Bump UR tag to ed9fe09 for L0 loader update (#16013)
21018ab 
Update UR tag to pull in
oneapi-src/unified-runtime#2279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igchor igchor igchor approved these changes

@EwanC EwanC EwanC approved these changes

@pbalcer pbalcer Awaiting requested review from pbalcer

@fabiomestre fabiomestre Awaiting requested review from fabiomestre

@aarongreig aarongreig Awaiting requested review from aarongreig

Assignees
No one assigned
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrspruit @EwanC @igchor @callumfare