fix: type should match code - export default Systemic is not correct, switch to export = Systemic#69
Merged
cressie176 merged 1 commit intoonebeyond:masterfrom Nov 6, 2025
Conversation
export default Systemic is not correct, switch to export = Systemicexport default Systemic is not correct, switch to export = Systemic
9 tasks
loveirobert-ob
approved these changes
Nov 5, 2025
UlisesGascon
approved these changes
Nov 5, 2025
victor-hernandez-one-beyond
approved these changes
Nov 5, 2025
Betisman
approved these changes
Nov 5, 2025
Collaborator
|
Hey @PeterAronZentai / @nochtap can you help me with the permissions... seems like I can't land the PR. I wanted to do the release as I did for onebeyond/systemic-service-runner#13. Otherwise the types will be a bit messy 😅. Thanks in advance! ❤️ |
|
Hi @UlisesGascon |
cressie176
approved these changes
Nov 6, 2025
Merged
Collaborator
|
It is now available in systemic@5.0.0 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types are not correct, they are not aligned with the code.
Similar to onebeyond/systemic-service-runner#13
Related Issue
Didn't open an issue, should I do it?
Motivation and Context
This is an issue users encounter if they try to consume this module from an ESM service.
export default Systemicshould be used if in the js file we were doingexport default Systemic;-> the package is exported as a ES module.When exporting a CJS module instead (like we're doing here with
module.exports = ...) the type definition should beexport = Systemic;Typescript is probably clever enough to not raise any error when consuming this in a CJS service, but in an ESM environment it's raising an error, see screenshot of linked issue, it's the same
How Has This Been Tested?
This is a change only in the types, I've tried it changing the type definition directly in the node_modules both in a ESM service and in a CJS service
Types of changes
Checklist: