Merge pull request #72 from onfido/test/fix-evidence-folder-test

test: wait for evidence folder to be available
onfido · Jan 20, 2025 · d2fd834 · d2fd834
2 parents 2b7a327 + b42cdae
commit d2fd834
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/test/OnfidoTestCase.php b/test/OnfidoTestCase.php
@@ -176,7 +176,7 @@ protected function repeatRequestUntilStatusChanges(
         callable $function,
         array $params,
         string $status,
-        $maxRetries = 10,
+        $maxRetries = 15,
         $sleepTime = 1
     )
     {
@@ -199,7 +199,7 @@ protected function repeatRequestUntilStatusChanges(
     protected function repeatRequestUntilTaskOutputChanges(
         callable $function,
         array $params,
-        $maxRetries = 10,
+        $maxRetries = 15,
         $sleepTime = 1
     )
     {
@@ -222,7 +222,7 @@ protected function repeatRequestUntilTaskOutputChanges(
     protected function repeatRequestUntilHttpCodeChanges(
         callable $function,
         array $params,
-        $maxRetries = 10,
+        $maxRetries = 15,
         $sleepTime = 1
     )
     {

diff --git a/test/Resource/ReportsTest.php b/test/Resource/ReportsTest.php
@@ -48,12 +48,21 @@ public function testListReports(): void
 
     public function testFindReport(): void
     {
+        $findReportFn = function($reportId) {
+            return self::$onfido->findReport($reportId);
+        };
+
+        $getDocumentReport = $this->repeatRequestUntilStatusChanges(
+            $findReportFn,
+            [$this->documentReportId],
+            ReportStatus::COMPLETE
+        );
         $getDocumentReport = self::$onfido->findReport($this->documentReportId);
         $getIdentityReport = self::$onfido->findReport($this->identityReportId);
 
         $this->assertSame($this->documentReportId, $getDocumentReport->getId());
         $this->assertSame(ReportName::DOCUMENT, $getDocumentReport->getName());
-        $this->assertSame(ReportStatus::AWAITING_DATA, $getDocumentReport->getStatus());
+        $this->assertSame(ReportStatus::COMPLETE, $getDocumentReport->getStatus());
 
         $this->assertSame($this->identityReportId, $getIdentityReport->getId());
         $this->assertSame(ReportName::IDENTITY_ENHANCED, $getIdentityReport->getName());

diff --git a/test/Resource/WorkflowRunsTest.php b/test/Resource/WorkflowRunsTest.php
@@ -124,7 +124,14 @@ public function testDownloadEvidenceFolder(): void
           WorkflowRunStatus::APPROVED
         )->getOutput();
 
-        $file = self::$onfido->downloadEvidenceFolder($workflowRunId);
+        $getEvidenceFolderFn = function($workflowRunId) {
+          return self::$onfido->downloadEvidenceFolder($workflowRunId);
+        };
+
+        $file = $this->repeatRequestUntilHttpCodeChanges(
+          $getEvidenceFolderFn,
+          [$workflowRunId]
+        );
 
         $this->assertGreaterThan(0, $file->getSize());
     }