Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for onfido-python library #54

Merged
merged 12 commits into from
May 22, 2024
Merged

Conversation

sofia-gomes-onfido
Copy link
Contributor

@sofia-gomes-onfido sofia-gomes-onfido commented May 16, 2024

Includes tests for the following instances:

  • applicants
  • address
  • webhooks
  • checks
  • documents
  • extraction
  • live photos
  • live videos
  • motion
  • reports (including detailed validation of schemas)
  • SDK token
  • tasks
  • workflow runs (including detailed validation of output schemas)
  • watchlist monitors

@sofia-gomes-onfido sofia-gomes-onfido force-pushed the test/add-tests branch 8 times, most recently from bfa4e5c to 3d6fe7d Compare May 17, 2024 09:48
@sofia-gomes-onfido sofia-gomes-onfido marked this pull request as ready for review May 17, 2024 14:55
assert get_identity_report.actual_instance.id == identity_report_id
assert get_identity_report.actual_instance.name == ReportName.IDENTITY_ENHANCED
assert get_identity_report.actual_instance.status == ReportStatus.COMPLETE

Copy link
Contributor

@dvacca-onfido dvacca-onfido May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be worth it accessing a few fields specific to the report type to validate that works as well?

@sofia-gomes-onfido sofia-gomes-onfido merged commit 0f0abe3 into master May 22, 2024
8 checks passed
@sofia-gomes-onfido sofia-gomes-onfido deleted the test/add-tests branch June 5, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants