Add tests for Download NFC Face endpoint #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiogoAndreBotas
force-pushed
the
add-tests-for-download-nfc-face-endpoint
branch
4 times, most recently
from
dbe2ac7 to
838be34
Compare
Add tests for /documents/{document_id}/nfc_face endpoint, added to the OpenAPI spec in onfido/onfido-openapi-spec@c479418
DiogoAndreBotas
force-pushed
the
add-tests-for-download-nfc-face-endpoint
branch
from
838be34 to
c89d283
Compare
dvacca-onfido
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
LGTM. CI is red because PR comes from a fork.
@sofia-gomes-onfido could you please have a look also?
sofia-gomes-onfido
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
/documents/{document_id}/nfc_faceendpoint, added to the OpenAPI spec in onfido/onfido-openapi-spec@c479418