Set coordinate_transformation_mode=asymmetric when rewriting Upsample to Reshape to get same output. #3096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Need to investigate why onnx-runtime and the backend tests have different results
Before the rewrite would rewrite to an reshape with the default
coordinate_transformation_mode = "half_pixel"
, but this leads to a different output when comparing with onnx runtime.Tested using onnx runtime, with one model having a Reshape Op and one an Upsample. With
coordinate_transformation_mode = "half_pixel"
the output had some differences, withcoordinate_transformation_mode = "asymmetric"
the output was the same.Comment in ORT about this: microsoft/onnxruntime#1179 (comment)
IMO the onnx documentation for Upsample is not very detailed and its hard to know how to do the Upsample -> Reshape rewrite when just looking at the documentation.