Skip to content

Prevent SIP.js stack to crash app on re-register when there is already an outstanding REGISTER request #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adaxi
Copy link
Contributor

@adaxi adaxi commented Apr 23, 2025

In our code base we took the approach of using the full API framework instead of using the SimpleUser class.

We instantiate the Registerer to register our user agent.

In some cases we are getting this uncaught error by the SIP.js stack causing our nodejs process to stop.

REGISTER request already in progress, waiting for final response

From my analysis this can happen if we attempt to call the register function, and in parallel the re-register function is called on timeout.

I have opted to check if the waiting flag is set instead of blindly catching the exception, but I am open to other suggestions.

@adaxi adaxi force-pushed the uncaught-re-register-failure branch from c3ff95f to d430c71 Compare April 23, 2025 10:01
@adaxi adaxi changed the title Prevent crash app on re-register when there is an outstanding registration Prevent SIP.js stack to crash app on re-register when there is already an outstanding REGISTER request Apr 23, 2025
@adaxi adaxi force-pushed the uncaught-re-register-failure branch 2 times, most recently from e6d3a17 to 7b7c527 Compare April 23, 2025 10:04
@adaxi adaxi force-pushed the uncaught-re-register-failure branch from 7b7c527 to 6df34f7 Compare April 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant