Prevent SIP.js stack to crash app on re-register when there is already an outstanding REGISTER request #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code base we took the approach of using the full API framework instead of using the SimpleUser class.
We instantiate the
Registerer
to register our user agent.In some cases we are getting this uncaught error by the SIP.js stack causing our nodejs process to stop.
From my analysis this can happen if we attempt to call the register function, and in parallel the re-register function is called on timeout.
I have opted to check if the waiting flag is set instead of blindly catching the exception, but I am open to other suggestions.