Skip to content

added slovak (sk) translation#1415

Open
martinkovacik wants to merge 1 commit intoopen-circle:mainfrom
martinkovacik:main
Open

added slovak (sk) translation#1415
martinkovacik wants to merge 1 commit intoopen-circle:mainfrom
martinkovacik:main

Conversation

@martinkovacik
Copy link

@martinkovacik martinkovacik commented Mar 5, 2026

Hello, here is a PR with slovak language for i18n.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added Slovak (sk) language localization support to the i18n package, enabling Slovak validation messages and language-specific schemas across all modules.

Copilot AI review requested due to automatic review settings March 5, 2026 18:20
@vercel
Copy link

vercel bot commented Mar 5, 2026

@kovacik-redbyte is attempting to deploy a commit to the Open Circle Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 5, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

This pull request adds Slovak language support to the i18n package. Changes include a new Slovak localization module with validation messages, updated export configurations in package and JSR manifests to expose Slovak modules, modifications to build scripts to process the new language, and expansion of the Language type union to include the 'sk' code.

Changes

Cohort / File(s) Summary
Package Configuration
packages/i18n/package.json, packages/i18n/jsr.json, packages/i18n/.gitignore
Extended public exports to expose Slovak modules (sk and ~60 sub-modules). Added "sk" to published files list and excludes, with both CommonJS and ES module entry points configured for each module.
Build Scripts
packages/i18n/scripts/build-jsr.ts, packages/i18n/scripts/build-npm.ts
Imported Slovak language module and added it to the languages array, enabling the build process to generate Slovak export entries and schemas alongside existing languages.
Source & Types
packages/i18n/src/sk.ts, packages/i18n/src/types.ts
Introduced Slovak localization module with validation messages mapped to Slovak strings and a Language object with code 'sk'. Updated Language.code union type to recognize 'sk' as a valid language code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hop and skip to Slovakia's shore,
Where validation speaks in tongues once more,
SK exports bloom in patterns neat,
Making i18n translations complete! 🌍✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding Slovak translation support to the i18n package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the enhancement New feature or request label Mar 5, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/i18n/src/types.ts (1)

3-31: Prefer interface for this object-shape export.

Language is an object shape, so using interface here would align with repository conventions.

♻️ Suggested refactor
-export type Language = {
+export interface Language {
   code:
     | 'ar'
@@
-    | 'zh-TW';
+    | 'zh-TW';
   schema: ErrorMessage<BaseIssue<unknown>>;
   specific: {
@@
   };
-};
+}

As per coding guidelines, **/*.ts: Prefer interface over type for defining object shapes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/i18n/src/types.ts` around lines 3 - 31, The exported object-shape
alias Language should be converted from a type to an exported interface to match
repo conventions: replace "export type Language = { code: ... }" with "export
interface Language { code: ... }" preserving the exact union of string literals
for the code property and the export name Language so existing imports/usages
continue to work; no behavior changes are needed—just change the declaration
form to interface Language with the same members.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/i18n/src/types.ts`:
- Around line 3-31: The exported object-shape alias Language should be converted
from a type to an exported interface to match repo conventions: replace "export
type Language = { code: ... }" with "export interface Language { code: ... }"
preserving the exact union of string literals for the code property and the
export name Language so existing imports/usages continue to work; no behavior
changes are needed—just change the declaration form to interface Language with
the same members.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8032f862-ccd8-4ff9-ab46-5868a4399963

📥 Commits

Reviewing files that changed from the base of the PR and between 1454eeb and c1cd86a.

📒 Files selected for processing (7)
  • packages/i18n/.gitignore
  • packages/i18n/jsr.json
  • packages/i18n/package.json
  • packages/i18n/scripts/build-jsr.ts
  • packages/i18n/scripts/build-npm.ts
  • packages/i18n/src/sk.ts
  • packages/i18n/src/types.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants