added slovak (sk) translation#1415
Conversation
|
@kovacik-redbyte is attempting to deploy a commit to the Open Circle Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis pull request adds Slovak language support to the i18n package. Changes include a new Slovak localization module with validation messages, updated export configurations in package and JSR manifests to expose Slovak modules, modifications to build scripts to process the new language, and expansion of the Language type union to include the 'sk' code. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/i18n/src/types.ts (1)
3-31: Preferinterfacefor this object-shape export.
Languageis an object shape, so usinginterfacehere would align with repository conventions.♻️ Suggested refactor
-export type Language = { +export interface Language { code: | 'ar' @@ - | 'zh-TW'; + | 'zh-TW'; schema: ErrorMessage<BaseIssue<unknown>>; specific: { @@ }; -}; +}As per coding guidelines,
**/*.ts: Preferinterfaceovertypefor defining object shapes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/i18n/src/types.ts` around lines 3 - 31, The exported object-shape alias Language should be converted from a type to an exported interface to match repo conventions: replace "export type Language = { code: ... }" with "export interface Language { code: ... }" preserving the exact union of string literals for the code property and the export name Language so existing imports/usages continue to work; no behavior changes are needed—just change the declaration form to interface Language with the same members.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/i18n/src/types.ts`:
- Around line 3-31: The exported object-shape alias Language should be converted
from a type to an exported interface to match repo conventions: replace "export
type Language = { code: ... }" with "export interface Language { code: ... }"
preserving the exact union of string literals for the code property and the
export name Language so existing imports/usages continue to work; no behavior
changes are needed—just change the declaration form to interface Language with
the same members.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8032f862-ccd8-4ff9-ab46-5868a4399963
📒 Files selected for processing (7)
packages/i18n/.gitignorepackages/i18n/jsr.jsonpackages/i18n/package.jsonpackages/i18n/scripts/build-jsr.tspackages/i18n/scripts/build-npm.tspackages/i18n/src/sk.tspackages/i18n/src/types.ts
Hello, here is a PR with slovak language for i18n.
Summary by CodeRabbit
Release Notes