Skip to content

🌱 remove deprecated work execution clusterrolebinding #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zhiweiyin318
Copy link
Member

Summary

The open-cluster-management:{{ .KlusterletName }}-work:execution clusterRoleBinding has been deprecated for several releases, now remove the manifest and cleanup codes.

Related issue(s)

#985

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.20%. Comparing base (c9b3b6f) to head (7315ed8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...usterletcontroller/klusterlet_managed_reconcile.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   64.22%   64.20%   -0.02%     
==========================================
  Files         195      195              
  Lines       19078    19078              
==========================================
- Hits        12252    12249       -3     
- Misses       5817     5819       +2     
- Partials     1009     1010       +1     
Flag Coverage Δ
unit 64.20% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhiweiyin318 zhiweiyin318 reopened this May 15, 2025
@zhiweiyin318 zhiweiyin318 reopened this May 27, 2025
@zhiweiyin318 zhiweiyin318 force-pushed the remove-rbac branch 2 times, most recently from d7a8719 to 2c58b19 Compare May 27, 2025 09:01
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3d7d770 into open-cluster-management-io:main May 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants