[WIP] Fix default judge model selection conflict in run.py and tools.py#1532
Open
TianhaoLiang2000 wants to merge 2 commits into
Open
[WIP] Fix default judge model selection conflict in run.py and tools.py#1532TianhaoLiang2000 wants to merge 2 commits into
TianhaoLiang2000 wants to merge 2 commits into
Conversation
mzr1996
requested changes
May 14, 2026
Collaborator
mzr1996
left a comment
There was a problem hiding this comment.
Please move the judge model selection to the benchmark class (for example, a class attribute), and this function will use the class attribute and dataset type to determine the final judge model name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR centralizes the default judge model selection logic into
vlmeval/judge.pyand makes bothrun.pyandvlmeval/tools.py::EVAL()use the same source of truth.Changes
get_default_judge_model()invlmeval/judge.py.run.py::get_judge_kwargs()to reuse the shared default judge resolver.vlmeval/tools.py::EVAL()to use the same resolver instead of its older hardcoded defaults.chatgpt-0125default for MCQ / Y-N evaluation throughtools.py::EVAL().MMBench_VideoandMMBench-Videodataset naming.Testing
python -m py_compile run.py vlmeval/tools.py vlmeval/judge.pypre-commit runpassed during commit.pre-commit run --all-fileswas also run; it fails only on pre-existing flake8 issues outside this PR's changed files.