[Cleanup] Remove unused Polygon3 dependency (#1528)#1548
Open
SHAI-Akshay-Tripathi wants to merge 4 commits into
Open
[Cleanup] Remove unused Polygon3 dependency (#1528)#1548SHAI-Akshay-Tripathi wants to merge 4 commits into
SHAI-Akshay-Tripathi wants to merge 4 commits into
Conversation
…licts The generate_kwargs dict passed top_p, top_k, and temperature to model.generate() without setting do_sample. HuggingFace defaults do_sample to False, which silently ignores sampling parameters and falls back to greedy decoding, causing evaluation results to not reflect the configured sampling behavior. This commit derives do_sample from temperature (do_sample=True when temperature > 0) and only includes top_p, top_k, and temperature in generate_kwargs when sampling is enabled, avoiding conflicting-flag warnings in the greedy path. Users can override via kwargs. Closes open-compass#1275
Removed polygon3 dependency from requirements.
Removed 'Polygon3' from the requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1528.
Polygon3was listed in two requirements files but is not imported or usedanywhere in the codebase. As noted in #1528, the package bundles the GPC
component which carries proprietary licensing terms (
Other/Proprietary Licenseon PyPI), which can create friction for commercial users.Changes
Polygon3fromrequirements.txtPolygon3fromvlmeval/dataset/utils/Ocrbench_v2/requirements.txtVerification
Searched the full codebase for any usage of Polygon3 / GPC: