Skip to content

Conversation

@JVickery-TBS
Copy link

@JVickery-TBS JVickery-TBS commented Jan 19, 2026

Backport of ckan#8421 for required stuffs to allow for metadata_modified and metadata_created schemas.

amercader and others added 2 commits January 19, 2026 14:00
package_update: faster dataset metadata update
# Conflicts:
#	ckan/lib/dictization/__init__.py
#	ckan/lib/dictization/model_save.py
#	ckan/logic/action/create.py
#	ckan/logic/action/patch.py
#	ckan/logic/action/update.py
#	ckan/logic/schema.py
#	ckan/plugins/interfaces.py
#	ckan/types/__init__.py
#	ckanext/example_idatasetform/plugin.py
#	ckanext/example_iuploader/test/test_plugin.py
### RESOLVED.
- Allow sysadmins to set metadata_created during package create.
- Added change log file.
- Brought back support for the package_extras table.
@JVickery-TBS
Copy link
Author

@wardi okay a BIT tricky on the cherry-pick but I think I solved all merge conflicts. And then ran into an issue with the package updating, but then remembered 2.10 is still on the package_extras table. So I modified that dictize save method to have a changed flag like the others. And that is working now.

I also tried adding in the schema for the metadata_created - hopefully that works. I will throw in some automated tests in our ckanext-canada plugin, so sysadmins should hopefully be able to set those values upon create.

- Allow sysadmins to set metadata_modified for resources.

# (canada fork only): metadata_created for data migrations
# TODO: upstream contrib!!
schema['metadata_created'] = [ignore]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a sysadmin should be able to set this even with an update call

Copy link
Member

@wardi wardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that one suggestion, otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants