Skip to content

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Feb 27, 2025

Previous discussion in #174. I created this new branch issue-171-clean from issue-171 because the merge conflicts were more annoying to resolve than doing this.

  • The title refers to work done on the OpenEphys.Onix1 overview page
  • "Aggregate", "Multi-Device" -> "Device Group" throughout the docs
  • Add css classes for badges
  • Define what devices are in api/configure.md and api/device-configure.md
  • I wanted to link to properties in the tables which motivated me to fix the xref issue Property xref should go to property #70. That's what the changes are related to in the .js files are concerning.
  • Reduce excessive formatting (specifically hyperlinks don't need to be wrapped in back ticks)
  • Remove comments that appear in HTML inspector

Resolve #171
Resolve #70

- This is done on the OpenEphys.Onix1 overview page
- "Aggregate", "Multi-Device" -> "Device Group"
- Add css classes for badges
- Define what devices are on the configuration operator pages
- I wanted to link to properties in the tables which motivated me to fix the xref issue #70. This fix seems to work well enough for now. That's what the changes are related to in the .js files are concerning.
- Reduce excessive formatting (specifically hyperlinks don't need to be wrapped in back ticks)
- Remove comments that appear in HTML inspector
cjsha and others added 2 commits February 27, 2025 14:19
- Some edits to descriptions and page layout
- Add image of property pane
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes, looks good.

- There was an unnecessary include that was removed and causing a broken reference
@cjsha cjsha merged commit a8c83d0 into main Mar 7, 2025
3 checks passed
@cjsha cjsha deleted the issue-171-clean branch March 7, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistancy in Devices versus acquisition, and configuration tags Property xref should go to property

2 participants