Skip to content

Conversation

@bparks13
Copy link
Member

@bparks13 bparks13 commented Sep 6, 2024

Utilizing the new utility script, call the same script from the Actions runs to ensure consistency between local and remote builds.

Note that the only one not connected right now is the Lychee step; there is a pre-existing action on Github that is used in the actions, so it is not necessarily the same call. However, we rely on the user as of now to download or install the lychee executable locally for themselves, so there are bound to be some differences there. It should provide enough consistency for now, and we can revisit it later if it becomes an issue.

@bparks13 bparks13 requested a review from cjsha September 6, 2024 20:20
@bparks13 bparks13 self-assigned this Sep 6, 2024
@bparks13 bparks13 added this to the Infrastructure milestone Sep 6, 2024
@bparks13 bparks13 requested a review from jonnew September 10, 2024 14:12
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brandon, sorry for the delayed review.

@bparks13
Copy link
Member Author

Due to weird issues merging this PR, PR #68 was merged instead, which is a carbon copy of this PR.

@bparks13 bparks13 closed this Sep 24, 2024
@bparks13 bparks13 deleted the testing-actions branch September 24, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants