Skip to content

Upgrade clroni to .net8.0 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade clroni to .net8.0 #43

wants to merge 5 commits into from

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Jun 24, 2025

@jonnew
Upgrade clroni to .net8.0
a84bd89 
- Take advantage of the API improvements afforded by this framework
- Follow best practices for P/Invoke: https://learn.microsoft.com/en-us/dotnet/standard/native-interop/best-practices
- DllImport -> LibraryImport
- Use [In] and [Out] attributes on array parameters and dont use
  StringBuilder
@jonnew jonnew requested a review from aacuevas June 24, 2025 17:43
@jonnew jonnew marked this pull request as draft June 24, 2025 18:17
@aacuevas
Copy link
Collaborator

I have patched this PR in my personal repo so it allows for multitarget building, targeting both framewotk 4.7 and net 8.0, so it can be used in new and old projects alike.
I do not know how to make a PR to a PR, so, for the time being it is in https://github.com/aacuevas/liboni/tree/issue-25
@jonnew please take a look whenever you have the time

@jonnew jonnew marked this pull request as ready for review October 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aacuevas aacuevas Awaiting requested review from aacuevas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dependency from WindowsDesktop framework

2 participants

@jonnew @aacuevas