Skip to content

update SDK for demo #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddbaert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update SDK for demo #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
<groupId>dev.openfeature</groupId>
<artifactId>sdk</artifactId>
<!-- 1.16.0 <= v < 2.0 (excluding 2.0 pre-releases)-->
<version>[1.16.0,1.99999)</version>
<version>1.19.1</version>
Copy link

@gemini-code-assist gemini-code-assist bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning the sdk dependency to a specific version reduces flexibility for consumers. For a library ecosystem, it's generally better to use a version range to declare compatibility with a range of SDK versions that a consuming application might provide.

  • If this change is intentional and permanent, please update the comment on line 103, as it's now inconsistent with the fixed version.
  • If flexibility is desired, please consider reverting to a version range. The standard Maven range would be [1.16.0,2.0.0). The previous [1.16.0,1.99999) was likely a way to exclude pre-releases of 2.0, which is also a valid approach.

For future consideration, managing this version via a Maven property could offer a good balance of control and flexibility for child modules.

<!-- use the version provided at runtime -->
<scope>provided</scope>
</dependency>
Expand Down
Loading