Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open-formulieren/open-forms#3805] Fix label if field is not required #638

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jan 26, 2024

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3daa5ba) 54.84% compared to head (6e1a0bd) 73.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #638       +/-   ##
===========================================
+ Coverage   54.84%   73.73%   +18.88%     
===========================================
  Files         216      220        +4     
  Lines        3949     4500      +551     
  Branches      716     1195      +479     
===========================================
+ Hits         2166     3318     +1152     
+ Misses       1580     1143      -437     
+ Partials      203       39      -164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Jan 26, 2024
@sergei-maertens sergei-maertens merged commit 1a698cd into main Jan 26, 2024
12 checks passed
@sergei-maertens sergei-maertens deleted the issue/3805-required branch January 26, 2024 15:26
@sergei-maertens
Copy link
Member

Backports:

1.4.x and older gives too many merge conflicts, so those have been skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause form modal "Uw e-mailadres" required is inverse?
2 participants