[OF#2617] Retrieve needsPayment value from submission #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed from submission The way to show the payment step in the progress indicator and to start the payment form was through the form. Since we want to have access to the price rules as well, we had to have access to the submission. So, the submission is now the one which tells us if a form needs payment.
vaszig
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 74.85% 74.50% -0.36%
==========================================
Files 224 224
Lines 4542 4542
Branches 1211 1212 +1
==========================================
- Hits 3400 3384 -16
- Misses 1103 1122 +19
+ Partials 39 36 -3 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Feb 2, 2024
sergei-maertens
deleted the
of-2617-take-needspayment-from-submission-not-from-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#2617