Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump storybook to 7.0.27 #646

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Feb 19, 2024

Had to just entirely nuke yarn.lock to get this to work since apparently multi-version dependency resolution is not properly fixed/implemented in yarn 😒

Some dependencies are now pinned more specifically in package.json because they were causing visual regressions.

@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch from 886f458 to ab34d41 Compare February 19, 2024 13:25
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fa4b2b) 74.85% compared to head (6e99fe9) 73.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   74.85%   73.69%   -1.17%     
==========================================
  Files         225      225              
  Lines        4546     4547       +1     
  Branches     1212     1213       +1     
==========================================
- Hits         3403     3351      -52     
- Misses       1104     1157      +53     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch 3 times, most recently from f361df8 to 4383acd Compare February 19, 2024 16:34
@sergei-maertens
Copy link
Member Author

@nikkiysendoorn1 can you check out this branch and try if it resolves your storybook issues for you?

@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch from 4383acd to b72be5d Compare February 19, 2024 18:02
I had to nuke the  file to get this to work properly :(
@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch from b72be5d to 3f65921 Compare February 19, 2024 18:04
@nikkiysendoorn1
Copy link
Contributor

@sergei-maertens It is not working. I get the same error as yesterday :(

@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch 3 times, most recently from 9812917 to 41538ce Compare February 20, 2024 12:05
@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook-patch branch from 41538ce to 6e99fe9 Compare February 21, 2024 08:40
@sergei-maertens sergei-maertens merged commit 498ec9e into main Feb 21, 2024
14 of 15 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-storybook-patch branch February 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants