Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#3855] Catch API errors on start submission #647

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

SilviaAmAm
Copy link
Contributor

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (cbe0014) 74.26% compared to head (e961c31) 73.98%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/components/Form.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   74.26%   73.98%   -0.29%     
==========================================
  Files         225      225              
  Lines        4546     4547       +1     
  Branches     1212     1214       +2     
==========================================
- Hits         3376     3364      -12     
- Misses       1131     1144      +13     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would an error boundary not be better? 🤔

@SilviaAmAm SilviaAmAm force-pushed the feature/3855-error-on-form branch from aefe8fd to e961c31 Compare February 21, 2024 12:33
@SilviaAmAm SilviaAmAm marked this pull request as ready for review February 21, 2024 12:40
@sergei-maertens sergei-maertens merged commit d3996be into main Feb 22, 2024
16 of 19 checks passed
@sergei-maertens sergei-maertens deleted the feature/3855-error-on-form branch February 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for a better DMN user experience for both editor and end-user
2 participants