Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade storybook to 8.6.3 #799

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

sergei-maertens
Copy link
Member

Monthly storybook upgrade :)

Monthly storybook upgrade :)
Copy link

codecov bot commented Mar 3, 2025

Bundle Report

Changes will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB 7 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 7 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/sdk-*.js 7 bytes 1.01MB 0.0%

Files in assets/sdk-*.js:

  • ./src/components/LanguageSelection/LanguageSelection.jsx → Total Size: 2.42kB
view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 7 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/components/LanguageSelection/LanguageSelection.jsx → Total Size: 2.42kB

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (adf8ff7) to head (b3d8770).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         246      246           
  Lines        4817     4818    +1     
  Branches     1275     1282    +7     
=======================================
+ Hits         4046     4047    +1     
  Misses        742      742           
  Partials       29       29           
Flag Coverage Δ
storybook 77.68% <100.00%> (+0.09%) ⬆️
vitest 62.56% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Turned up via failing test in Chromatic, which was locally reproducible.

Likely there was a race condition in the original assertion, and the
SB upgrade revealed the underlying bug, huray.
@sergei-maertens sergei-maertens merged commit 93099d6 into main Mar 3, 2025
17 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-storybook branch March 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant