Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5074] Transform data for selectboxes in the registrations (variables tab) #5130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 28, 2025

Closes #5074

Changes

  • Add checkbox for transforming the data to a list for Objects API and JSON dump registations (variables tab)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft February 28, 2025 16:13
@vaszig vaszig changed the title [#5074] Transform data for selectboxes in the variables tab [#5074] Transform data for selectboxes in the registrations (variables tab) Feb 28, 2025
@vaszig vaszig force-pushed the feature/5074-transform-to-list-checkbox-for-selectboxes branch from ed55597 to 465c9b7 Compare March 3, 2025 07:38
@vaszig vaszig mentioned this pull request Mar 3, 2025
13 tasks
@vaszig vaszig force-pushed the feature/5074-transform-to-list-checkbox-for-selectboxes branch from 465c9b7 to 595f1bb Compare March 3, 2025 07:39
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (a517a16) to head (9e2ee4b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5130   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         779      779           
  Lines       26774    26787   +13     
  Branches     3483     3486    +3     
=======================================
+ Hits        25903    25916   +13     
  Misses        607      607           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaszig vaszig force-pushed the feature/5074-transform-to-list-checkbox-for-selectboxes branch 2 times, most recently from aedeec0 to 0d022ba Compare March 5, 2025 12:13
@vaszig vaszig marked this pull request as ready for review March 5, 2025 12:16
@vaszig vaszig requested a review from sergei-maertens March 5, 2025 13:00
@sergei-maertens sergei-maertens self-requested a review March 10, 2025 13:46
@sergei-maertens sergei-maertens force-pushed the feature/5074-transform-to-list-checkbox-for-selectboxes branch from 6f4b421 to 1bb557b Compare March 11, 2025 12:56
@vaszig vaszig force-pushed the feature/5074-transform-to-list-checkbox-for-selectboxes branch from 1bb557b to 9e2ee4b Compare March 11, 2025 17:44
@vaszig vaszig requested a review from sergei-maertens March 12, 2025 08:09
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate some storybook stories for the selectboxes component type and alternative UI 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On registration, transform selectboxes data shape based on openForms.transformData
2 participants