-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5074] Transform data for selectboxes
in the registrations (variables tab)
#5130
base: master
Are you sure you want to change the base?
[#5074] Transform data for selectboxes
in the registrations (variables tab)
#5130
Conversation
selectboxes
in the variables tabselectboxes
in the registrations (variables tab)
ed55597
to
465c9b7
Compare
465c9b7
to
595f1bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5130 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 779 779
Lines 26774 26787 +13
Branches 3483 3486 +3
=======================================
+ Hits 25903 25916 +13
Misses 607 607
Partials 264 264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aedeec0
to
0d022ba
Compare
6f4b421
to
1bb557b
Compare
src/openforms/js/components/admin/form_design/registrations/json_dump/JSONDumpOptionsForm.js
Outdated
Show resolved
Hide resolved
.../components/admin/form_design/registrations/json_dump/JSONDumpVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
.../components/admin/form_design/registrations/json_dump/JSONDumpVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
1bb557b
to
9e2ee4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate some storybook stories for the selectboxes component type and alternative UI 😬
Closes #5074
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene