Skip to content

update track-first-steps-progress.md (fixes #3585) #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

munishpatel
Copy link
Member

@munishpatel munishpatel commented Mar 10, 2025

Important: Do not tick a checkbox if you haven’t performed its action.

Before Creating the Pull Request

  • Verify the changes are on a new branch other than master – it should say "compare: branch-name".
  • Start the pull request title with lowercase letters, e.g., add githubusername.md.
  • Add issue number to the end of the pull request title when applicable, e.g., update mi-faq.md (fixes #3264).

After Creating the Pull Request

  • Go to "Commits" tab, make sure the commit username is clickable and linked to your GitHub account correctly.
  • Review the "Files changed" tab to ensure there are no unnecessary files or changes included in the pull request.
  • Verify that the raw.githack preview link is included in the description.
    • Preview the MDwiki rendered changes using the raw.githack link. Ensure it displays as expected without any errors.
  • Drop a link to this pull request in our discord channel.

Description, Screenshots and/or Screencast

<--Made changes in the code for track-first-steps-progress.md file for creating the comments count. -->

fixes #3585

Raw.Githack Preview Link

<-- https://raw.githack.com/munishpatel/munishpatel.github.io/3585-add-comments-count/index.html#!pages/track-first-steps-progress.md -->

@munishpatel munishpatel changed the title updated code for tracking progress (fixes #3585) update track-first-steps-progress.md (fixes #3585) Mar 10, 2025
Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to see the comments count in your raw githack.link. Please advise if I'm doing something wrong (note this output is for @Mutugi who should definitely have some comments to count). Feel free to provide your own screenshot.

image

@munishpatel munishpatel reopened this Mar 10, 2025
@munishpatel
Copy link
Member Author

I have made the required changes @jessewashburn . In the track-first-step-progress.md file we need to add a access token to access the Github's API. The below is the placeholder for the access token for your reference:
image

I executed the application using my personal access code, the below is the screenshot for your reference:
image

Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me what kind of output your getting for 'Mutugiii'? Mine is showing 0 comments, which isn't right.
image

Also, can you manually verify that the 4 comments it's counting for you is an accurate count? I'm not sure.

@munishpatel
Copy link
Member Author

I guess that's because the function is checking the issues which are in "OPEN" state.
While checking the 'Mutugiii' tracking process, I am getting an rate limit exceeded error in my api call.
After checking manually I have 4 comments on the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

track-first-step-progress: comments count not visible
2 participants