fix(ui): add missing i18n keys and fix mistyped key references - #30572
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
a2adf08 to
1c59b53
Compare
1c59b53 to
1178601
Compare
1178601 to
16aa76d
Compare
Several t() calls referenced translation keys that do not exist in the locale files, so they rendered the raw key string in the UI. - Add 27 genuinely-missing keys to en-us.json with proper translations for all supported locales (label.*, message.*, server.api-error). - Fix references that were typos for / better served by an existing key: message.entity-fetch-error -> server.entity-fetch-error message.unexpected-error -> server.unexpected-error message.no-application-schema-found -> server.no-application-schema-found message.no-entity-available -> label.no-entity-available message.paste-odps-yaml-here -> server.paste-odps-yaml-here message.please-select-user-first -> message.select-user-first label.user-verified-successfully -> message.user-verified-successfully label.no-glossary-found -> message.no-entity-found-for-name label.no-tags -> label.no-entity Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
16aa76d to
5642108
Compare
|
d5d45ae
Code Review ✅ Approved 2 resolved / 2 findingsAdds 27 missing internationalization keys and corrects mistyped translation references across UI components and locale files, resolving the empty-state and tag-form localization findings. ✅ 2 resolved✅ Bug: no-entity-available key needs {{entity}} arg not passed in tagFormFields
✅ Bug: Glossary empty-state renders dangling 'found for ' with no name
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source |
* fix(ui): add missing i18n keys and fix mistyped key references Several t() calls referenced translation keys that do not exist in the locale files, so they rendered the raw key string in the UI. - Add 27 genuinely-missing keys to en-us.json with proper translations for all supported locales (label.*, message.*, server.api-error). - Fix references that were typos for / better served by an existing key: message.entity-fetch-error -> server.entity-fetch-error message.unexpected-error -> server.unexpected-error message.no-application-schema-found -> server.no-application-schema-found message.no-entity-available -> label.no-entity-available message.paste-odps-yaml-here -> server.paste-odps-yaml-here message.please-select-user-first -> message.select-user-first label.user-verified-successfully -> message.user-verified-successfully label.no-glossary-found -> message.no-entity-found-for-name label.no-tags -> label.no-entity Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci(playwright): provision Reindex lane for Domain impact rule The Domain/DataProduct impact rule selects '**/*Domain*.spec.ts', which matches Features/SearchSeparation/DomainRenamePrefixCascade.spec.ts. That spec is only collectable under the 'Reindex' project, so selecting it without provisioning that lane makes the shard planner fail with "selectors matched no runnable tests". Add Reindex to the rule's projects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit d5d45ae)



Problem
Several
t()calls reference translation keys that don't exist in the locale files. i18next then renders the raw key string (e.g.message.no-test-case-found) in the UI instead of a translated label. Found by scanning allt('literal.key')usages againsten-us.json.Changes
1. Fix references that were typos for / better served by an existing key (no new key added):
message.entity-fetch-errorserver.entity-fetch-errormessage.unexpected-errorserver.unexpected-errormessage.no-application-schema-foundserver.no-application-schema-foundmessage.no-entity-availablelabel.no-entity-availablemessage.paste-odps-yaml-hereserver.paste-odps-yaml-heremessage.please-select-user-firstmessage.select-user-firstlabel.user-verified-successfullymessage.user-verified-successfullylabel.no-glossary-foundmessage.no-entity-found-for-namelabel.no-tagslabel.no-entity2. Add 27 genuinely-missing keys to
en-us.json(label.*,message.*,server.api-error), each referenced by unconditional (non-embedded) product code. Interpolation vars ({{entity}},{{field}},{{appName}},{{pipelineName}}) preserved to match the call sites. Real translations provided for all supported locales (not English placeholders).Verification
yarn check-i18npasses.🤖 Generated with Claude Code
Greptile Summary
Corrects invalid i18n key references and adds missing translations across supported locales.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (7): Last reviewed commit: "Merge branch 'main' into fix/missing-i18..." | Re-trigger Greptile