Skip to content

Fixed the knowledge center translations - #30521

Merged
Rohit0301 merged 6 commits into
mainfrom
knowledge-center-translations
Jul 29, 2026
Merged

Fixed the knowledge center translations#30521
Rohit0301 merged 6 commits into
mainfrom
knowledge-center-translations

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Screenshot 2026-07-27 at 6 37 03 PM Screenshot 2026-07-27 at 6 39 07 PM Screenshot 2026-07-27 at 7 02 22 PM

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • UI & Branding Updates:
    • Renamed knowledge center components and labels to context center across the UI (KnowledgeCenterFilterPage.tsx, KnowledgeCenterWidget.tsx, KnowledgePages.tsx)
    • Updated entity type and search index labels from knowledge page/article to article (SearchClassBase.ts, EntityNameUtils.ts)
  • Localization Updates:
    • Updated translation keys for knowledge center, knowledge articles, and related terms across all language json files

This will update automatically on new commits.

Greptile Summary

This PR standardizes Knowledge Center terminology as Context Center and Article across the UI.

  • Updates labels, translations, breadcrumbs, entity names, and empty or permission states.
  • Adjusts Context Center article UI and Playwright tests for the renamed navigation.
  • Revises hierarchy move messaging and memory visibility descriptions.

Confidence Score: 3/5

The PR is not yet safe to merge because Shared memories still cannot be assigned the recipients required by the newly displayed visibility contract.

The create and edit form submits Shared visibility without sharedWith principals, while backend authorization grants non-owner access only to principals in that list, so selecting Shared cannot produce the recipient-visible state promised by the UI.

Files Needing Attention: openmetadata-ui/src/main/resources/ui/src/constants/ContextCenter.constants.ts; openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/CreateMemoryModal/CreateMemoryModal.component.tsx

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/constants/ContextCenter.constants.ts Updates the Shared-memory description to recipient-specific wording, while the outstanding recipient-configuration gap remains.
openmetadata-ui/src/main/resources/ui/src/components/KnowledgeCenter/KnowledgePagesHierarchy/KnowledgePagesHierarchy.tsx Renames article terminology and introduces dedicated top-level move confirmation copy.
openmetadata-ui/src/main/resources/ui/src/utils/EntityNameUtils.ts Aligns Context Center entity display names with the new Article terminology.
openmetadata-ui/src/main/resources/ui/src/utils/SearchClassBase.ts Updates search-facing Context Center and Article labels.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterArticles.spec.ts Updates Explore navigation assertions and selectors for Context Center and Articles.

Reviews (5): Last reviewed commit: "lint fix" | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Jul 27, 2026
@Rohit0301
Rohit0301 requested a review from a team as a code owner July 27, 2026 12:02
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

Comment thread openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json Outdated
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.72% (76874/116961) 49.56% (46131/93071) 50.81% (13907/27368)

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 2971ce724dbf778a64dbdd6305868afa0061dc0d in Playwright run 30385901826, attempt 1.

✅ 704 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 1h 4m 42s

⏱️ Max setup 2m 56s · max shard execution 20m 3s · max shard-job elapsed before upload 23m 35s · reporting 4s

🌐 184.46 requests/attempt · 2.68 app boots/UI scenario · 33.92% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 33.92% (convergence target: at most 15%).
  • Application boot ratio was 2.68 per UI scenario (2023 boots / 754 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
🟡 Shard chromium-01 206 0 1 0 0 0
✅ Shard chromium-02 140 0 0 0 0 0
✅ Shard chromium-03 101 0 0 0 0 0
✅ Shard chromium-04 119 0 0 3 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 23 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 27 0 0 2 0 0
🟡 1 flaky test(s) (passed on retry)
  • Features/ContextCenterMemories.spec.tsadding a linked asset in edit mode shows entity badge on the row (shard chromium-01, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301
Rohit0301 added this pull request to the merge queue Jul 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2026
@Rohit0301
Rohit0301 enabled auto-merge July 28, 2026 18:06
@sonarqubecloud

Copy link
Copy Markdown

@Rohit0301
Rohit0301 added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit 204c6c9 Jul 29, 2026
78 of 80 checks passed
@gitar-bot

gitar-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Updates UI components and translation keys to rebrand Knowledge Center terminology to Context Center and Article. No issues found.

✅ 1 resolved
Quality: pr-pr.json new translation added in Spanish, not Persian

📄 openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json:4292
In pr-pr.json (Persian locale) the newly added key "visible-to-specific-people" was given a Spanish string ("Visible para personas específicas con las que lo compartes.") while the other two added keys ("no-articles-available", "top-level") were correctly translated to Persian. This produces a mixed-language string for Persian users. Replace it with the correct Persian translation (e.g. "فقط برای افرادی که با آن‌ها به اشتراک می‌گذارید قابل مشاهده است.").

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants