fix(playwright-ci): add ContextCenter/KnowledgeCenter to impact-map.json - #30554
Conversation
…ap.json Maps all ContextCenter/KnowledgeCenter frontend components, pages, REST APIs, backend Java resources (context, knowledge, drive packages), repository classes, search indexes, and spec schemas to the relevant Playwright E2E specs so that changes to any of these paths trigger the correct test suite on PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
✅ Playwright Results — workflow succeededValidated commit ✅ 536 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 50m 31s ⏱️ Max setup 2m 49s · max shard execution 18m 17s · max shard-job elapsed before upload 21m 56s · reporting 4s 🌐 203.24 requests/attempt · 2.87 app boots/UI scenario · 4.38% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
None of the ContextCenter specs carry the @basic tag so scheduling them under the Basic project produced an empty assignment with no tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review ✅ ApprovedAdds ContextCenter and KnowledgeCenter source paths to impact-map.json so that relevant E2E test suites run properly during pull requests. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source |
…son (#30554) * fix(playwright-ci): add ContextCenter and KnowledgeCenter to impact-map.json Maps all ContextCenter/KnowledgeCenter frontend components, pages, REST APIs, backend Java resources (context, knowledge, drive packages), repository classes, search indexes, and spec schemas to the relevant Playwright E2E specs so that changes to any of these paths trigger the correct test suite on PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(playwright-ci): remove Basic project from ContextCenter mapping None of the ContextCenter specs carry the @basic tag so scheduling them under the Basic project produced an empty assignment with no tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Describe your changes:
I worked on adding ContextCenter and KnowledgeCenter to the Playwright CI impact map because changes to these features (both frontend and backend) were not triggering the relevant E2E test suites on PRs. For example, PR #30521 changed backend resources under
resources/context/,resources/knowledge/, andresources/drive/but no ContextCenter Playwright tests ran.Type of change:
High-level design:
Added a new entry to
.github/playwright/impact-map.jsonthat maps all ContextCenter/KnowledgeCenter source paths (frontend components, pages, REST API clients, constants, utils, backend Java resource/repository/search classes, and JSON spec schemas) to the 7 relevantFeatures/ContextCenter*.spec.tsPlaywright specs. Thenightly/ContextCenter.spec.tsintentionally stays indelegatedSpecs(too slow for PRs).Tests:
Use cases covered
resources/context,resources/knowledge,resources/drive, related repositories and search indexes) now trigger ContextCenter Playwright specs on PRsopenmetadata-specalso trigger the specsUnit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
Verified the changed file paths match the source patterns in
select_playwright_tests.pyand align with the existing mapping conventions used for Glossary, Domain, DataQuality, and other features.UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Greptile Summary
The PR expands Playwright impact selection for ContextCenter and KnowledgeCenter changes.
chromiumproject.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the mapped specs are runnable under chromium, and the previously reported Basic-project selection issue is fixed.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(playwright-ci): remove Basic project..." | Re-trigger Greptile