Skip to content

fix(playwright-ci): add ContextCenter/KnowledgeCenter to impact-map.json - #30554

Merged
Rohit0301 merged 2 commits into
mainfrom
playwright-ci-skip-analysis
Jul 28, 2026
Merged

fix(playwright-ci): add ContextCenter/KnowledgeCenter to impact-map.json#30554
Rohit0301 merged 2 commits into
mainfrom
playwright-ci-skip-analysis

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

I worked on adding ContextCenter and KnowledgeCenter to the Playwright CI impact map because changes to these features (both frontend and backend) were not triggering the relevant E2E test suites on PRs. For example, PR #30521 changed backend resources under resources/context/, resources/knowledge/, and resources/drive/ but no ContextCenter Playwright tests ran.

Type of change:

  • Improvement

High-level design:

Added a new entry to .github/playwright/impact-map.json that maps all ContextCenter/KnowledgeCenter source paths (frontend components, pages, REST API clients, constants, utils, backend Java resource/repository/search classes, and JSON spec schemas) to the 7 relevant Features/ContextCenter*.spec.ts Playwright specs. The nightly/ContextCenter.spec.ts intentionally stays in delegatedSpecs (too slow for PRs).

Tests:

Use cases covered

  • Changes to any ContextCenter/KnowledgeCenter frontend component, page, REST file, or constant now trigger ContextCenter Playwright specs on PRs
  • Changes to backend Java packages (resources/context, resources/knowledge, resources/drive, related repositories and search indexes) now trigger ContextCenter Playwright specs on PRs
  • Changes to ContextCenter JSON schemas in openmetadata-spec also trigger the specs

Unit tests

  • Not applicable (CI configuration change only)

Backend integration tests

  • Not applicable (no backend API changes)

Ingestion integration tests

  • Not applicable (no ingestion changes)

Playwright (UI) tests

  • Not applicable (this PR fixes the CI mapping so the tests run — no new test code added)

Manual testing performed

Verified the changed file paths match the source patterns in select_playwright_tests.py and align with the existing mapping conventions used for Glossary, Domain, DataQuality, and other features.

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

The PR expands Playwright impact selection for ContextCenter and KnowledgeCenter changes.

  • Maps relevant frontend, backend, search, repository, and schema paths to seven existing feature specs.
  • Assigns those specs to the runnable chromium project.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the mapped specs are runnable under chromium, and the previously reported Basic-project selection issue is fixed.

Important Files Changed

Filename Overview
.github/playwright/impact-map.json Adds the ContextCenter and KnowledgeCenter source-to-spec mapping and corrects the prior ineffective Basic-project assignment by selecting chromium.

Reviews (2): Last reviewed commit: "fix(playwright-ci): remove Basic project..." | Re-trigger Greptile

…ap.json

Maps all ContextCenter/KnowledgeCenter frontend components, pages, REST APIs,
backend Java resources (context, knowledge, drive packages), repository classes,
search indexes, and spec schemas to the relevant Playwright E2E specs so that
changes to any of these paths trigger the correct test suite on PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Rohit0301
Rohit0301 requested review from a team, akash-jain-10, harshach and tutte as code owners July 28, 2026 08:08
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@Rohit0301 Rohit0301 self-assigned this Jul 28, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Jul 28, 2026
@github-actions github-actions Bot added the UI UI specific issues label Jul 28, 2026
Comment thread .github/playwright/impact-map.json Outdated
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 224b91c5809ca79d9da98e663e95b3ac02caea1b in Playwright run 30346036329, attempt 1.

✅ 536 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 50m 31s

⏱️ Max setup 2m 49s · max shard execution 18m 17s · max shard-job elapsed before upload 21m 56s · reporting 4s

🌐 203.24 requests/attempt · 2.87 app boots/UI scenario · 4.38% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 203.24 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.87 per UI scenario (1604 boots / 559 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 143 0 0 3 0 0
🟡 Shard chromium-02 132 0 1 0 0 0
✅ Shard chromium-03 123 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 23 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 27 0 0 2 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsDomain Propagation (shard chromium-02, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

None of the ContextCenter specs carry the @basic tag so scheduling them
under the Basic project produced an empty assignment with no tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Rohit0301
Rohit0301 enabled auto-merge July 28, 2026 10:39
@Rohit0301
Rohit0301 added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 7f3bcc0 Jul 28, 2026
75 of 77 checks passed
@Rohit0301
Rohit0301 deleted the playwright-ci-skip-analysis branch July 28, 2026 14:26
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds ContextCenter and KnowledgeCenter source paths to impact-map.json so that relevant E2E test suites run properly during pull requests. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

Rohit0301 added a commit that referenced this pull request Jul 28, 2026
…son (#30554)

* fix(playwright-ci): add ContextCenter and KnowledgeCenter to impact-map.json

Maps all ContextCenter/KnowledgeCenter frontend components, pages, REST APIs,
backend Java resources (context, knowledge, drive packages), repository classes,
search indexes, and spec schemas to the relevant Playwright E2E specs so that
changes to any of these paths trigger the correct test suite on PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(playwright-ci): remove Basic project from ContextCenter mapping

None of the ContextCenter specs carry the @basic tag so scheduling them
under the Basic project produced an empty assignment with no tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants