Skip to content

fix(ui): update styling imports and fix CSS specificity - #30563

Merged
chirag-madlani merged 3 commits into
mainfrom
fix-lineage-panel-styling
Jul 30, 2026
Merged

fix(ui): update styling imports and fix CSS specificity#30563
chirag-madlani merged 3 commits into
mainfrom
fix-lineage-panel-styling

Conversation

@chirag-madlani

@chirag-madlani chirag-madlani commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes:

Fixes #

Screen.Recording.2026-07-28.at.2.50.00.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • UI Styles & Lineage:
    • Added React Flow and entity lineage styling imports in LineageProvider.tsx
    • Updated CSS specificity and layout rules for React Flow panels and minimap in entity-lineage.style.less

This will update automatically on new commits.

Greptile Summary

Updates lineage styling behavior:

  • Loads React Flow and entity-lineage styles through LineageProvider.
  • Scopes panel and minimap positioning overrides to lineage containers.
  • Removes the redundant component-level lineage stylesheet import.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/CustomNodeV1.component.tsx Removes the component-level lineage stylesheet import now provided by the lineage context module.
openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/entity-lineage.style.less Scopes React Flow panel and minimap offsets to the lineage container while retaining global panel margin and minimap presentation rules.
openmetadata-ui/src/main/resources/ui/src/components/Lineage/Lineage.component.tsx Contains only a formatting-only blank-line change.
openmetadata-ui/src/main/resources/ui/src/context/LineageProvider/LineageProvider.tsx Centralizes React Flow and entity-lineage stylesheet loading in the provider used by the production lineage render paths.

Reviews (3): Last reviewed commit: "fix checkstyle" | Re-trigger Greptile

@chirag-madlani
chirag-madlani requested a review from a team as a code owner July 28, 2026 09:21
Copilot AI review requested due to automatic review settings July 28, 2026 09:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jul 28, 2026
@chirag-madlani chirag-madlani added skip-pr-checks Bypass PR metadata validation check UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch and removed UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jul 28, 2026
Rohit0301
Rohit0301 previously approved these changes Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.72% (76875/116962) 49.56% (46131/93067) 50.81% (13907/27368)

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 11bcf009d83877fbe5bde397ecb69b90dcfa4d48 in Playwright run 30367159911, attempt 2.

✅ 667 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 2h 27m 34s

⏱️ Max setup 3m 3s · max shard execution 16m 36s · max shard-job elapsed before upload 27m 52s · reporting 6s

🌐 212.20 requests/attempt · 3.03 app boots/UI scenario · 10.94% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 212.2 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 3.03 per UI scenario (2093 boots / 691 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 102 0 0 0 0 0
🟡 Shard chromium-02 110 0 1 3 0 0
✅ Shard chromium-03 101 0 0 0 0 0
✅ Shard chromium-04 98 0 0 0 0 0
✅ Shard chromium-05 118 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 23 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 27 0 0 2 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsDomain Propagation (shard chromium-02, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Copilot AI review requested due to automatic review settings July 28, 2026 12:58
@chirag-madlani
chirag-madlani enabled auto-merge July 28, 2026 16:18
@chirag-madlani
chirag-madlani added this pull request to the merge queue Jul 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2026
@chirag-madlani
chirag-madlani added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026
@chirag-madlani
chirag-madlani added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026
@chirag-madlani
chirag-madlani added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 1c753b7 Jul 30, 2026
99 of 101 checks passed
@chirag-madlani
chirag-madlani deleted the fix-lineage-panel-styling branch July 30, 2026 14:21
@github-actions

Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 2.0 branch.

github-actions Bot pushed a commit that referenced this pull request Jul 30, 2026
* fix(ui): update styling imports and fix CSS specificity

* fix checkstyle

(cherry picked from commit 1c753b7)
@gitar-bot

gitar-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates styling imports and CSS specificity for React Flow panels and minimap in the lineage view. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.13 branch.
Please cherry-pick the changes manually.
You can find more details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants